[AMOS commit] MDL-76053 admin: Remove various warnings related to MNet Committed into Git: 2022-10-27 21:06 UTC

[AMOS commit] MDL-76053 admin: Remove various warnings related to MNet Committed into Git: 2022-10-27 21:06 UTC

by AMOS bot -
Number of replies: 0
Author: Eloy Lafuente (stronk7)
MDL-76053 admin: Remove various warnings related to MNet
This partially reverts MDL-73270, where some useful environmental
checks and notifications in the admin UI were added to inform
about different parts of Moodle relying on the "unsupported"
php-xmlrpc extension.

Since then, some changes have happened in core, only available
for Moodle 4.1 and up (see the MDL-70889 mini-epic). Namely:

- MNet (SSO, roaming, auth, enrol and Mahara portfolio) are not
using the php-xmlrpc extension anymore, but a pure php library.
- The xmlrpc webservices protocol, has been move from core to
the Plugins directory, although it continues using the php-xmlrpc
extension.

Because of that here we are removing all the checks and notifications
related with MNet (not using the extension anymore), but keeping the
webservice plugin ones (still using the extension). Surely if some day the
protocol stops using the extension, we'll be able to remove the
corresponding checks too. But that's future.

Note the associated lang strings have been also removed (not deprecated)
because they were highly specific and hardly reusable:
- xmlrpcmaharaenabled
- xmlrpcmnetauthenticationenabled
- xmlrpcmnetenabled

And very same applies, because MNet doesn't contain anything deprecated
or not supported anymore, hence, straight deletion, to the function:
- mnet_get_deprecation_notice()

Also, related tests using any of the removed stuff above have been deleted.

In the other side, the "check_xmlrpc_usage" continues existing and
being used both by environment checks and admin notifications but,
as commented above, now it only looks for the xmlrpc webservice
protocol now.


http://git.moodle.org/gw?p=moodle.git;a=commit;h=621d75dbce569a25fe8bc0151216f98069224281
http://github.com/moodle/moodle/commit/621d75dbce569a25fe8bc0151216f98069224281

- 4.1 en [xmlrpcmaharaenabled,core_admin]
- 4.1 en [xmlrpcmnetauthenticationenabled,core_admin]
- 4.1 en [xmlrpcmnetenabled,core_admin]