Author: Mark Nelson
MDL-48012 tool_recyclebin: multiple changes before integration
- Added new icon for the recycle bin.
- Fixed issue where the course expiry setting was being used to display
the expiry messages in the category bin.
- Fixed failing Behat tests.
- Tidied Behat tests.
- General tidy up.
- Deleted three Behat feature files.
- Deleted 'delete_confirmation.feature' as it's testing JS functionality
that was removed (see comment further down). The 'basic_functionality.feature'
now tests deleting an activity and a course.
- Deleted 'description.feature' and added the tested functionality to
'basic_functionality.feature'.
- Deleted 'logs_test.feature' and moved testing to PHPUnit tests.
- Added another scenario for restoring a course.
- Removed protected mod settings - it was discussed that this was not a necessary
feature. We should not be treating the recycle bin as a backup.
- Renamed events to conform to guidelines.
- Wrote new PHPUnit tests for events.
- Tidied up existing PHPUnit tests and extended them.
- Alphabetised lang file.
- Made changes to strings and string identifiers in the lang file and changed usages in code.
- Changed setting names to better identify their purpose.
- Renamed classes and file names so it's easier to identify their purpose.
- Renamed the 'deleted' column to 'timecreated' for consistency with other
Moodle tables, and to easily identify what the value represents.
- Changed the columns 'category' and 'course' to 'categoryid' and
'courseid' respectively.
- Changed the name of the table indexes for consistency with core.
- Removed module.js and any use of it and replaced with Moodle core libraries
for JS confirmation.
- Removed 'noevent' argument in delete_item().
- Removed unnecessary capabilities - we can use the same capabilties for both
recycle bins based on the context the capability was given.
- Removed '_' in the capability definitions to keep it consistent with core.
- Set page layout and headings for index.php - varies between the course and
category recycle bins.
- Deleted styles.css and centred columns using the flexible_table API.
- Fixed IDE and codechecker complaints.
- Made use of the files API, rather than writing directly to
"$CFG->dataroot . '/recyclebin'".
- Used make_temp_directory rather than expecting it to exist.
- Replaced debugging function calls with calls to the backup API to
display errors.
- Deleted the temporary backup file after a successful restore, or if it fails.
- If the restore fails for a course, delete the course we created.
- Removed unnecessary '\' characters when not in namespace.
- Used configduration class for expiry times in the settings.
- Cleanup course bin when a course is deleted.
- Cleanup a category bin when a category is deleted.
- Removed unnecessary throw tags.
- Changed default settings.
http://git.moodle.org/gw?p=moodle.git;a=commit;h=93af6a610e6f139895144f3ccab4dfe9d78a69fc
http://github.com/moodle/moodle/commit/93af6a610e6f139895144f3ccab4dfe9d78a69fc
+ 3.1 en [alertdeleted,tool_recyclebin]
+ 3.1 en [alertemptied,tool_recyclebin]
+ 3.1 en [alertrestored,tool_recyclebin]
+ 3.1 en [autohide,tool_recyclebin]
+ 3.1 en [categorybinenable,tool_recyclebin]
+ 3.1 en [categorybinexpiry,tool_recyclebin]
+ 3.1 en [categorybinexpiry_desc,tool_recyclebin]
+ 3.1 en [coursebinenable,tool_recyclebin]
+ 3.1 en [coursebinexpiry,tool_recyclebin]
+ 3.1 en [coursebinexpiry_desc,tool_recyclebin]
+ 3.1 en [datedeleted,tool_recyclebin]
+ 3.1 en [deleteall,tool_recyclebin]
+ 3.1 en [deleteallconfirm,tool_recyclebin]
+ 3.1 en [deleteexpirywarning,tool_recyclebin]
+ 3.1 en [eventitemcreated,tool_recyclebin]
+ 3.1 en [eventitemcreated_desc,tool_recyclebin]
+ 3.1 en [eventitemdeleted,tool_recyclebin]
+ 3.1 en [eventitemdeleted_desc,tool_recyclebin]
+ 3.1 en [eventitemrestored,tool_recyclebin]
+ 3.1 en [eventitemrestored_desc,tool_recyclebin]
+ 3.1 en [noitemsinbin,tool_recyclebin]
+ 3.1 en [taskcleanupcategorybin,tool_recyclebin]
+ 3.1 en [taskcleanupcoursebin,tool_recyclebin]
+ 3.1 en [recyclebin:deleteitems,tool_recyclebin]
+ 3.1 en [recyclebin:restoreitems,tool_recyclebin]
+ 3.1 en [recyclebin:viewitems,tool_recyclebin]
- 3.1 en [cleancategoryrecyclebin,tool_recyclebin]
- 3.1 en [cleancourserecyclebin,tool_recyclebin]
- 3.1 en [course_expiry,tool_recyclebin]
- 3.1 en [course_expiry_desc,tool_recyclebin]
- 3.1 en [deleted,tool_recyclebin]
- 3.1 en [description_course,tool_recyclebin]
- 3.1 en [description_coursecat,tool_recyclebin]
- 3.1 en [descriptionexpiry,tool_recyclebin]
- 3.1 en [empty,tool_recyclebin]
- 3.1 en [emptybin,tool_recyclebin]
- 3.1 en [emptyconfirm,tool_recyclebin]
- 3.1 en [enablecategory,tool_recyclebin]
- 3.1 en [enablecategory_desc,tool_recyclebin]
- 3.1 en [enablecourse,tool_recyclebin]
- 3.1 en [enablecourse_desc,tool_recyclebin]
- 3.1 en [event_purged_description,tool_recyclebin]
- 3.1 en [event_purged_name,tool_recyclebin]
- 3.1 en [event_restored_description,tool_recyclebin]
- 3.1 en [event_restored_name,tool_recyclebin]
- 3.1 en [event_stored_description,tool_recyclebin]
- 3.1 en [event_stored_name,tool_recyclebin]
- 3.1 en [expiry,tool_recyclebin]
- 3.1 en [expiry_desc,tool_recyclebin]
- 3.1 en [protectedmods,tool_recyclebin]
- 3.1 en [protectedmods_desc,tool_recyclebin]
- 3.1 en [recyclebin:delete_course,tool_recyclebin]
- 3.1 en [recyclebin:delete_item,tool_recyclebin]
- 3.1 en [recyclebin:delete_protected_item,tool_recyclebin]
- 3.1 en [recyclebin:restore_course,tool_recyclebin]
- 3.1 en [recyclebin:restore_item,tool_recyclebin]
- 3.1 en [recyclebin:view_course,tool_recyclebin]
- 3.1 en [recyclebin:view_item,tool_recyclebin]