Greylisted strings that can be taken back in favour

Greylisted strings that can be taken back in favour

OlsenBente -
回帖数：27
Language pack maintainers的头像

I've come across these strings, that are still in use:

restorestage1
restorestage2
restorestage4
restorestage8
restorestage16
restorestage32
restorestage64
restorestage4action
restorestage8action
restorestage16action
currentstage1
currentstage2
currentstage4
currentstage8
currentstage16
backupstage4action

回复OlsenBente

Re: Greylisted strings that can be taken back in favour

MudrákDavid -
Language pack maintainers的头像
Hi Bente,

thanks for the report! I just removed all restorestage%, currentstage% and backupstage% strings from the greylist.
回复MudrákDavid

Ang: Re: Greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

Hi David

I do not believe that all restorestage% and currentstage% strings are used, I have only noticed the ones listed.

In addition I have found these in use too:

importcurrentstage0
importcurrentstage1
importcurrentstage2
importcurrentstage4
importcurrentstage8
importcurrentstage16
importbackupstage4action
backupstage1action
backupstage2action

回复OlsenBente

Ang: Re: More greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

I've found some more strings still in use:

displayformatcontinuous
displayformatdictionary
displayformatencyclopedia
displayformatentrylist
displayformatfaq
displayformatfullwithauthor
displayformatfullwithoutauthor

all in mod_glossary

回复OlsenBente

Re: Ang: Re: More greylisted strings that can be taken back in favour

MudrákDavid -
Language pack maintainers的头像
Thanks Bente,

all the reported strings were removed from the greylist.
回复OlsenBente

Re: Ang: Re: Greylisted strings that can be taken back in favour

MudrákDavid -
Language pack maintainers的头像

Hi Bente,

in backup code, there is a code like

get_string('restorestage'.$this->stage,'backup');

In this case, we can never be sure what restorestage strings can be used so the policy is to expect them all, even if you have not spotted them yet.

回复MudrákDavid

Ang: Re: Ang: Re: Greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

Hi David

Ok - thanks for the information, though I do not fully understand it, no worries, I got the main point 微笑

Here is some more strings that I have discovered in use:

core    messageprovider:errors
core    messageprovider:notices
core    skypeid
core_admin    configfrontpageloggedin
core_admin    tablenosave
core_message    loggedindescription
core_message    loggedoffdescription
mod_assignment    messageprovider:assignment_updates
mod_assignment    typeoffline
mod_data    headerlisttemplate
mod_data    namedate
mod_data    namefile
mod_data    namelatlong
mod_data    namemenu
mod_data    namemultimenu
mod_data    namenumber
mod_data    namepicture
mod_data    nameradiobutton
mod_data    nametext
mod_data    nametextarea
mod_data    nameurl
mod_forum    messageprovider:posts
qtype_calculated    calculatedsummary
qtype_calculatedmulti    addingcalculatedmulti
qtype_calculatedmulti    calculatedmultisummary
qtype_calculatedsimple    addingcalculatedsimple
qtype_calculatedsimple    calculatedsimplesummary
qtype_description    descriptionsummary
qtype_essay    essay_help
qtype_match    matchsummary
qtype_multianswer    multianswersummary
qtype_multichoice    multichoicesummary
qtype_numerical    numericalsummary
qtype_randomsamatch    randomsamatchsummary
qtype_shortanswer    shortanswersummary
qtype_truefalse    truefalsesummary

回复OlsenBente

Ang: Re: Ang: Re: Greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

Yet a few in use:

mod_assignment    typeoffline
mod_assignment    typeupload
mod_assignment    typeuploadsingle
mod_glossary    displayformatcontinuous
mod_glossary    displayformatdictionary
mod_glossary    displayformatencyclopedia
mod_glossary    displayformatentrylist
mod_glossary    displayformatfaq
mod_glossary    displayformatfullwithauthor
mod_glossary    displayformatfullwithoutauthor

& happy new year!

回复OlsenBente

Ang: Re: Ang: Re: Greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

More greys in use:

core_admin     tablenosave
core_message     loggedindescription
core_message     loggedoffdescription
mod_data     headeraddtemplate
mod_data    headerasearchtemplate
mod_data    headercsstemplate
mod_data    headerjstemplate
mod_data    headerrsstemplate
mod_data    headersingletemplate

回复OlsenBente

Ang: Greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

Yet a few:

downloadcsv,core_table
downloadxhtml,core_table
event2,mod_quiz
event6,mod_quiz

回复OlsenBente

Re: Ang: Greylisted strings that can be taken back in favour

MudrákDavid -
Language pack maintainers的头像
Thanks Bente,

I removed downloadcsv and downloadxhtml from the greylist. Those two Quiz strings were not greylisted.
回复MudrákDavid

Ang: Re: Ang: Greylisted strings that can be taken back in favour

OlsenBente -
Language pack maintainers的头像

Ok, am I seeing ghosts? Never mind, missed one:

[orderandpaging,mod_quiz] Order and paging

回复OlsenBente

回复: Greylisted strings that can be taken back in favour

SunZhigang -
Language pack maintainers的头像

2.0 [course_fullname_key,enrol_ldap]
2.0 [course_idnumber_key,enrol_ldap]
2.0 [course_shortname_key,enrol_ldap]
2.0 [course_summary_key,enrol_ldap]

回复OlsenBente

本讨论区帖子已移除

本讨论区帖子的内容已移除，无法再访问。
回复删除的用户

Re: Greylisted strings that can be taken back in favour

MudrákDavid -
Language pack maintainers的头像
Thanks for the report. I have removed all *description strings in all auth plugins from the greylist.
回复OlsenBente

回复: Greylisted strings that can be taken back in favour

SunZhigang -
Language pack maintainers的头像

2.1 [wanttowait_high,core_portfolio]

2.1 [wanttowait_moderate,core_portfolio]