Ralf,
What would you suggest ? We all want to have those typos corrected, mostly those in Moodle core.
German,
my very first idea is to do it in the same way as we do for other languages. Each user in AMOS can make suggestions and an 'en' maintainer confirms them.
The problem will be that lang file process for en file are different to other languages and place for storing ist different. But I think David should give us feedback. he knwos the processes best. Think David is on the way to hackfest in West Australia.
Ralf
ralf
Thanks guys for opening this. Yes, this is a known issue and there is even a feature request for it waiting in the tracker - see MDLSITE-1363. I am happy to read that you concluded the same solution as we did - that is to use AMOS for it.
The idea described in the tracker is that there will a new language pack "en_fix" introduced in AMOS. Everybody will be able to submit contributions to it and there there will its maintainers (like Helen and Mary from the docs team) who would be responsible for the review and eventual acceptance of the contribution (as we do with all languages in AMOS).
From time to time (ideally it is automated and thence can be done often), the changes in "en_fix" would be merged into the standard "en" and removed from "en_fix".
I believe it would work well. Any objections?
No objections; I think it makes perfect sense
Looks good also to me. My +1.
My +1 too
Yes please. Go ahead
No objections. Thanks for your help David
OK, so the new language pack en_fix has been created here in AMOS, with Mary Cooch and Helen Foster set as its maintainers (ladies, I expect you two are able to communicate some internal procedures to cooperate on incoming contributions, right?).
Although strings are not copied over to Moodle, please start using it as a tool to collect fixes of typos in the English language pack (and/or general improvements of English texts).
Although strings are not copied over to Moodle, please start using it as a tool to collect fixes of typos in the English language pack (and/or general improvements of English texts).
Although strings are not copied over to Moodle, please start using it as a tool to collect fixes of typos in the English language pack
In the meantime before getting this automated, surely just ping one of the core people to try and get fixes integrated (especially around releases?).
Dan
Thanks David,
I just submitted the suspected typos I nagged about before.
I apologize if I seemed rude. I lack English social skills. I am only a mexican veterinarian.
This en_fix language seems to be a very elegant and efficient solution.
My congratulations
Hi,
I thought the official language for Moodle was British English, but there are many words in Moodle 2.3 core with American spelling, such as "color" (69 cases) instead of "colour" (17 cases).
Some cases are within the string identifier (eg: 2.3 [selectcolor,core_editor] ) and I fear they can/should not be changed.
Are both spellings to be used indistinctly ?
Is it worth the time and effort to hunt down and change the American spelling of these English strings into British spelling ?
Shall we laugh about it and work on really important typos?
If they are in code they should not be changed. They usually are related to words in CSS or HTML, in which case the US spelling is correct.
But for actual strings in the GUI, yes, the en spelling should be Australian English which is 100% the same as UK English.
Hi German.
The "official" language for Moodle is actually the Australian English (hey mate!) and the default locale is set to en_AU.UTF8. That's basically the same as the British English though. So from this point of view, "Select your color" is a typo. However, some strings are copied over from upstream projects (like TinyMCE) which might be using en_US. So for core_editor and editor_tinymce strings, I would suggest to leave them as they are. They would be probably overwritten during the next upstream upgrade anyway.
There are some exceptions, too. Especially when the string eventually refers to an HTML or CSS syntax. Then the US spelling is correct (for example, some strings still use the legacy <font color="#ff0000"> tags or they refer to CSS property "background-color").
We do not fix typos in string identifiers usually. However, feel free to submit a patch for "color" in all other places - like themes (I used the AMOS Translator filter and found couple of them).