block_course_overview categorized as standard plugin

block_course_overview categorized as standard plugin

by Iñigo Zendegi Urzelai -
Number of replies: 3

Hi,

When i was reviewing the untranslated strings of the standard modules I've seen that today this week have shown up new strings for the block_course_overview module.

As long as that module isn't in core it should be categorized as non-standard plugins, shouldn't it?

Cheers.

In reply to Iñigo Zendegi Urzelai

Re: block_course_overview categorized as standard plugin

by David Mudrák -
Picture of Language pack maintainers

Good point, thanks Iñigo for raising it.

IIRC, the current behavior is that once a plugin has ever been a standard one, it would always remain enlisted among them. The block_course_overview was once standard plugin until it was removed from Moodle core in version 3.3. It would make sense to remove such plugins after a while / couple of versions in these cases.

In reply to David Mudrák

Er: Re: block_course_overview categorized as standard plugin

by Iñigo Zendegi Urzelai -

Thanks for your answer, David.

Been that the case, it would be a good idea moving that previousyly-standard-plugins to non-standard if it's not a lot of work (I tried to find those strings for a while in a standard Moodle installation until I realized they weren't standard). On the other hand, I've just seen that those strings are also included in the standard langpack, that's another side effect might deserve to change.

Speaking of that, another minor issue: I've seen that the standard 3.5 downloadable langpack has 26151 strings, but in AMOS only are 26107 strings, and that's something that the OCD inside me doesn't like at all; do you know why is that happening and which are those 44 strings?

In reply to Iñigo Zendegi Urzelai

Re: Er: Re: block_course_overview categorized as standard plugin

by David Mudrák -
Picture of Language pack maintainers

why is that happening and which are those 44 strings?

It is even more messy. On download.moodle.org, total number of strings in standard components is currently shown as 26154. But if you extract the en.zip you will actually find 26185 strings. And AMOS translator itself reports total of 26110 strings.

One particular reason for these differences are strings with the "_link" suffix in their id. They have special meaning when displaying a help popup and they should not be translated. So AMOS does not show them (and does not count them into those 26110 standard strings available for editing) while they are still present in the generated language packs.

Another case coming to my mind are certain empty strings in TinyMCE plugins. There was some special care needed related to not 100% accurate translation stats and certain corrections were applied. Details can be found at https://lang.moodle.org/mod/forum/discuss.php?d=3372.

I admit it would deserve some cleanup. AMOS has been continuously developed for years and various features were added. When some of them affected how strings were counted in a particular part of the processing-chain (e.g. in the translator UI or in the ZIP generation tasks), chances are that we did not properly update all other places. It is a clear bug for sure. And should be fixed. Eventually.